flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
166.2k stars 27.49k forks source link

Android platform view tests should not depend on retired repository #144034

Open goderbauer opened 8 months ago

goderbauer commented 8 months ago

See

https://github.com/flutter/flutter/blob/bb856079c40139fc732927c73f1e882d77234dc5/dev/integration_tests/android_views/pubspec.yaml#L19-L23

https://github.com/flutter/flutter/blob/bb856079c40139fc732927c73f1e882d77234dc5/dev/integration_tests/hybrid_android_views/pubspec.yaml#L16-L20

The https://github.com/flutter/goldens repository has been retired and was recently (Feb 9, 2024) archived. We should no longer depend on that. (See https://github.com/flutter/flutter/issues/144033 for some context).

Edit: while debugging https://github.com/flutter/flutter/issues/144033 it was unarchived.

goderbauer commented 8 months ago

The Android deferred component test is also depending on things in that repository: https://github.com/flutter/flutter/blob/bb856079c40139fc732927c73f1e882d77234dc5/dev/integration_tests/deferred_components_test/download_assets.sh