search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
165.71k stars 27.36k forks source link

[CP] Hotfix fragment shaders fix into stable #147389

Closed renancaraujo closed 5 months ago

renancaraujo commented 6 months ago

Issue Link

141296 #141838

Target

stable

PR Link

https://github.com/flutter/engine/pull/52400

Changelog Description

Fixes fragment shader loading on the web (canvaskit).

Impacted Users

All Flutter devs using fragment shaders on Flutter web projects.

Impact Description

A runtime crash. Currently, there is a bug when loading shader data for fragment shaders in runtime ( https://github.com/flutter/flutter/issues/141296). This makes shader-based views no to render as a result of the crash. The app may get unresponsive.

Workaround

There is no workaround

Risk

low

Test Coverage

yes

Validation Steps

Load a fragment shader on a flutter web project.

Reproducible sample: https://github.com/flutter/samples/tree/main/simple_shader

renancaraujo commented 6 months ago

This is a retrial of https://github.com/flutter/flutter/issues/144503

renancaraujo commented 5 months ago

Closing as it seems that this was added to flutter 3.22

github-actions[bot] commented 5 months ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.