[flutter_adaptive_scaffold] Inconsistant "Open navigation drawer" button status

gs0-debiotech commented 2 weeks ago

Steps to reproduce

I am constantly displaying the AppBar to have multiple actions available. When the app (web target) is in a large window, with no drawer needed, there is no "Open navigation drawer" button displayed. This is expected as the navigation is displayed in a rail.

When shrinking the window, the navigation rail is hidden, and the navigation should be using the drawer. However, the button for showing the drawer is not displayed.

When refreshing the page (with the small window), the "Open navigation drawer" button appears. However, when enlarging the windows (and making the navigation rail visible), the "Open navigation drawer" button stays visible (and do not trigger any action.

Expected results

The "Open navigation drawer" button should show and hide depending if the drawer is user for navigation or not (that is, according to the breakpoints).

Actual results

The "Open navigation drawer" button visibility is not updated according to if the navigation is based on the drawer or on the rail.

Code sample

```dart class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( routes: { ExtractRouteArguments.routeName: (_) => const ExtractRouteArguments() }, debugShowCheckedModeBanner: false, home: AdaptiveScaffold( destinations: const [ NavigationDestination(icon: Icon(Icons.abc), label: 'label'), NavigationDestination(icon: Icon(Icons.ac_unit), label: 'label'), ], appBar: AppBar( actions: [ IconButton( onPressed: () {}, icon: const Icon(Icons.add_chart_sharp)), ], ), appBarBreakpoint: Breakpoints.standard, useDrawer: true, ), ); } } ```

Screenshots or Video

Screenshots / Video demonstration

| Resize operation | Initial state | After resize | |---|---|---| | Shrink | ![image](https://github.com/flutter/flutter/assets/149700184/a92134f1-ab66-4581-9b96-d4185428d7ba) | ![image](https://github.com/flutter/flutter/assets/149700184/114d4785-8a80-4a94-9a30-c887de8f408c) | | Grow | ![image](https://github.com/flutter/flutter/assets/149700184/884be8c7-660d-4de9-874d-3e26b6f0575e) | ![image](https://github.com/flutter/flutter/assets/149700184/c131f751-9702-4067-8f76-500e42ce73f8) |

Logs

```console ```

Flutter Doctor output

Doctor output

```console [✓] Flutter (Channel stable, 3.19.6, on Microsoft Windows [Version 10.0.22631.3447], locale en-CA) • Flutter version 3.19.6 on channel stable at C:\Users\g.surrel\flutter\flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 54e66469a9 (9 days ago), 2024-04-17 13:08:03 -0700 • Engine revision c4cd48e186 • Dart version 3.3.4 • DevTools version 2.31.1 [✓] Windows Version (Installed version of Windows is version 10 or higher) [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) • Android SDK at C:\Users\g.surrel\AppData\Local\Android\Sdk • Platform android-34, build-tools 34.0.0 • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874) • All Android licenses accepted. [✗] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe) ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable. [✓] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.9.6) • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools • Visual Studio Build Tools 2022 version 17.9.34728.123 • Windows 10 SDK version 10.0.22621.0 [✓] Android Studio (version 2023.2) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874) [✓] VS Code (version 1.88.1) • VS Code at C:\Users\g.surrel\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.86.0 [✓] Connected device (2 available) • Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.3447] • Edge (web) • edge • web-javascript • Microsoft Edge 124.0.2478.51 [✓] Network resources • All expected network resources are available. ! Doctor found issues in 1 category. ```

darshankawar commented 2 weeks ago

Thanks for the report @gs0-debiotech I tried with the official example of the package with which I was able to see the open navigation drawer button as shown below while shrinking and growing the app screen size.

https://github.com/flutter/flutter/assets/67046386/5ad03ca9-e872-46d0-865b-703ebd94ccce

gs0-debiotech commented 2 weeks ago

The provided example (from the "Example" tab in Flutter pub) does not use the default constructor. I actually started from the smaller example directly in the readme. Trying out different things to answer you, I noticed something interesting to narrow down the problem:

I swapped the following code:

    smallBreakpoint: const WidthPlatformBreakpoint(end: 700),
    mediumBreakpoint: const WidthPlatformBreakpoint(begin: 700, end: 1000),
    largeBreakpoint: const WidthPlatformBreakpoint(begin: 1000),
    useDrawer: false,

With that one:

        appBar: AppBar(),
        useDrawer: true,
        appBarBreakpoint: Breakpoints.standard,

The changes are as follows:

Force drawer navigation
Remove the custom breakpoints (as it triggers another problematic case where the bottom navigation is shown even if the useDrawer=true, but that's maybe another bug to open).
Provide my own AppBar.

It turns out the problem appears only when providing appBar: AppBar() myself (which I need as I put some actions in there).

Here is a video of the problem: https://github.com/flutter/flutter/assets/149700184/3b2c51ec-78d2-491c-ac28-8be7571360b0

darshankawar commented 2 weeks ago

Thanks for the update. I was able to replicate the reported behavior per shown above.

stable, master flutter doctor -v

``` [!] Flutter (Channel stable, 3.19.6, on macOS 12.2.1 21D62 darwin-x64, locale en-GB) • Flutter version 3.19.6 on channel stable at /Users/dhs/documents/fluttersdk/flutter ! Warning: `flutter` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. ! Warning: `dart` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700 • Engine revision c4cd48e186 • Dart version 3.3.4 • DevTools version 2.31.1 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [!] Xcode - develop for iOS and macOS (Xcode 12.3) • Xcode at /Applications/Xcode.app/Contents/Developer ! Flutter recommends a minimum Xcode version of 13. Download the latest version or update via the Mac App Store. • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.21.0 [✓] Connected device (5 available) • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 11 (API 30) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 14.4.1 18D61 • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator) • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.4 19E2269 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.80 [✓] HTTP Host Availability • All required HTTP hosts are available ! Doctor found issues in 1 category. [!] Flutter (Channel master, 3.22.0-18.0.pre.53, on macOS 12.2.1 21D62 darwin-x64, locale en-GB) • Flutter version 3.22.0-18.0.pre.53 on channel master at /Users/dhs/documents/fluttersdk/flutter ! Warning: `flutter` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. ! Warning: `dart` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 098e7e7ff3 (4 hours ago), 2024-04-29 01:25:19 +0000 • Engine revision 752b146df7 • Dart version 3.5.0 (build 3.5.0-109.0.dev) • DevTools version 2.35.0-dev.16 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [!] Android toolchain - develop for Android devices (Android SDK version 30.0.3) • Android SDK at /Users/dhs/Library/Android/sdk ✗ cmdline-tools component is missing Run `path/to/sdkmanager --install "cmdline-tools;latest"` See https://developer.android.com/studio/command-line for more details. ✗ Android license status unknown. Run `flutter doctor --android-licenses` to accept the SDK licenses. See https://flutter.dev/docs/get-started/install/macos#android-setup for more details. [✓] Xcode - develop for iOS and macOS (Xcode 13.2.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 13C100 • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2) • IntelliJ at /Applications/IntelliJ IDEA.app • Flutter plugin version 65.1.4 • Dart plugin version 213.7228 [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.29.0 [✓] Connected device (3 available) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 15.3.1 19D52 • macOS (desktop) • macos • darwin-x64 • macOS 12.2.1 21D62 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 109.0.5414.119 [✓] Network resources • All expected network resources are available. ! Doctor found issues in 1 category. [!] Xcode - develop for iOS and macOS (Xcode 12.3) • Xcode at /Applications/Xcode.app/Contents/Developer ! Flutter recommends a minimum Xcode version of 13. Download the latest version or update via the Mac App Store. • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.21.0 [✓] Connected device (5 available) • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 11 (API 30) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 14.4.1 18D61 • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator) • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.4 19E2269 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.80 [✓] HTTP Host Availability • All required HTTP hosts are available ! Doctor found issues in 1 category. ```

flutter / flutter