flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
162.18k stars 26.64k forks source link

[macOS] Eliminate flutter_gallery_macos__start_up benchmark #147442

Closed cbracken closed 2 weeks ago

cbracken commented 2 weeks ago

The macOS devicelab machines are not physically configured for benchmarking at a 60 Hz refresh rate. With Flutter vsync wired up via CVDisplayLink (rather than a hardcoded 60 Hz rate as previously), the bot shows 0 monitors configured and syncs at 30 Hz. This is not a meaningful target to measure against but consumes devicelab CPU cycles.

Given that there is currently no plan in place to acquire and configure a consistent pool of physical benchmarking desktop machines, disabling this test to reduce load on the bots.

See https://github.com/flutter/engine/pull/51210 for a discussion of the decision to move forward with wiring up vsync from macOS and ignore this benchmark.

For future archaeologists, I don't think it's worth removing all the plumbing in the Dart code (in dev/devicelab/lib/tasks/perf_tests.dart) that supports running this benchmark on macOS. If we ever acquire hardware suitable for benchmarking with the appropriate HDMI dongle to simulate a 60Hz 4k display, for example, it would be reasonable to re-enable this benchmark.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

auto-submit[bot] commented 2 weeks ago

auto label is removed for flutter/flutter/147442, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.