Closed nate-thegrate closed 1 week ago
Based on issue #144903, this pull request aims to bring the codebase more in line with the Flutter repo style guide:
Avoid using if chains or ?: or == with enum values
if
?:
==
// before bool get shown { if (overlayEntry == null) { return false; } if (animationController != null) { return animationController!.status == AnimationStatus.completed || animationController!.status == AnimationStatus.forward; } return true; } // after bool get shown { return overlayEntry != null && switch (animationController?.status) { AnimationStatus.forward || AnimationStatus.completed || null => true, AnimationStatus.reverse || AnimationStatus.dismissed => false, }; }
This pull request is similar to a previous PR with the same name but has a bit more thorough refactoring overall.
@nate-thegrate Are you interested in getting contributor access by the way? I'd be happy to sponsor you.
@justinmc That would be awesome, thank you very much!
Based on issue #144903, this pull request aims to bring the codebase more in line with the Flutter repo style guide:
This pull request is similar to a previous PR with the same name but has a bit more thorough refactoring overall.