search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
162.2k stars 26.64k forks source link

DropdownMenu does not highlight correct selected item #147516

Closed albe-jj closed 5 days ago

albe-jj commented 2 weeks ago

Steps to reproduce

With the following code, when item with label test is selected the item with label my test is selected instead, Although the object has different uuid. if I select bla or test 1 then it works as expected.

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Custom Dropdown Menu',
      home: DropdownMenuExample(),
    );
  }
}

class DropdownMenuExample extends StatefulWidget {
  @override
  _DropdownMenuExampleState createState() => _DropdownMenuExampleState();
}

class _DropdownMenuExampleState extends State<DropdownMenuExample> {
  MyObject? selectedValue;

  @override
  Widget build(BuildContext context) {
    List<MyObject> items = [
    MyObject(
      name: 'my test',
      uuid: '3fa85f64-5617-4562-b3fc-2c963f66afa6',
    ),
    MyObject(
      name: "bla",
      uuid: "4fa85f64-5717-4562-b3fc-2c963f66afa6",

    ),
    MyObject(
      name: "test",
      uuid: "3fa85f64-5717-4562-b3fc-2c963f68afa6",
    ),
    MyObject(
      name: "test 2",
      uuid: "3fa85f64-5717-4562-b3fc-2c963f66afa6",
    ),

  ];
    return Scaffold(
      appBar: AppBar(
        title: Text('Custom Dropdown Menu'),
      ),
      body: Center(
        child: DropdownMenu<MyObject>(
          initialSelection: selectedValue,

          onSelected: (MyObject? newValue) {
            setState(() {
              selectedValue = newValue;
            });
          },
          dropdownMenuEntries: items.map<DropdownMenuEntry<MyObject>>((MyObject scope) {
            return DropdownMenuEntry<MyObject>(
              value: scope,
              label: scope.name,
            );
          }).toList(),
        ),
      ),
    );
  }
}

class MyObject {
  final String name;
  final String uuid;

  MyObject({
    required this.name,
    required this.uuid,
  });
}

Expected results

if I select test then test should be highlighted the next time the menu is opened.

Actual results

With the following code, when item with label test is selected the item with label my test is selected instead, Although the object has different uuid. if I select bla or test 1 then it works as expected.

Code sample

Code sample ``` dart import 'package:flutter/material.dart'; void main() { runApp(MyApp()); } class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: 'Custom Dropdown Menu', home: DropdownMenuExample(), ); } } class DropdownMenuExample extends StatefulWidget { @override _DropdownMenuExampleState createState() => _DropdownMenuExampleState(); } class _DropdownMenuExampleState extends State { MyObject? selectedValue; @override Widget build(BuildContext context) { List items = [ MyObject( name: 'my test', uuid: '3fa85f64-5617-4562-b3fc-2c963f66afa6', ), MyObject( name: "bla", uuid: "4fa85f64-5717-4562-b3fc-2c963f66afa6", ), MyObject( name: "test", uuid: "3fa85f64-5717-4562-b3fc-2c963f68afa6", ), MyObject( name: "test 2", uuid: "3fa85f64-5717-4562-b3fc-2c963f66afa6", ), ]; return Scaffold( appBar: AppBar( title: Text('Custom Dropdown Menu'), ), body: Center( child: DropdownMenu( initialSelection: selectedValue, onSelected: (MyObject? newValue) { setState(() { selectedValue = newValue; }); }, dropdownMenuEntries: items.map>((MyObject scope) { return DropdownMenuEntry( value: scope, label: scope.name, ); }).toList(), ), ), ); } } class MyObject { final String name; final String uuid; MyObject({ required this.name, required this.uuid, }); } ```

Screenshots or Video

Screenshots / Video demonstration [Upload media here]

Logs

Logs ```console [Paste your logs here] ```

Flutter Doctor output

Doctor output ```console [✓] Flutter (Channel beta, 3.22.0-0.1.pre, on macOS 14.4.1 23E224 darwin-arm64, locale en-GB) [✗] Android toolchain - develop for Android devices ✗ Unable to locate Android SDK. Install Android Studio from: https://developer.android.com/studio/index.html On first launch it will assist you in installing the Android SDK components. (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions). If the Android SDK has been installed to a custom location, please use `flutter config --android-sdk` to update to that location. [!] Xcode - develop for iOS and macOS (Xcode 15.3) ✗ Unable to get list of installed Simulator runtimes. [✓] Chrome - develop for the web [!] Android Studio (not installed) [✓] VS Code (version 1.87.2)```
diegonc commented 2 weeks ago

Maybe related to https://github.com/flutter/flutter/issues/147253?

darshankawar commented 2 weeks ago

@albe-jj Can you try making use of key to see if it helps in your case or not ? Also check https://github.com/flutter/flutter/issues/103266 for further reference.

albe-jj commented 2 weeks ago

@albe-jj Can you try making use of key to see if it helps in your case or not ? Also check #103266 for further reference.

DorpdownMenuEntry has no property key https://api.flutter.dev/flutter/material/DropdownMenuEntry-class.html (key is for DropdownMenuItem used in dropdown button)

Note that with DropdownButton the selection is correct, it's when using DropdownMenu that selection goes wrong

albe-jj commented 2 weeks ago

Maybe related to #147253?

indeed seems related

darshankawar commented 2 weeks ago

Thanks for the update. I was able to replicate the reported behavior. The reported behavior occurs with test and my test items while selecting with respect to selection labels. The same doesn't occur while selecting bla and test 1.

stable, master flutter doctor -v ``` [!] Flutter (Channel stable, 3.19.6, on macOS 12.2.1 21D62 darwin-x64, locale en-GB) • Flutter version 3.19.6 on channel stable at /Users/dhs/documents/fluttersdk/flutter ! Warning: `flutter` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. ! Warning: `dart` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700 • Engine revision c4cd48e186 • Dart version 3.3.4 • DevTools version 2.31.1 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [!] Xcode - develop for iOS and macOS (Xcode 12.3) • Xcode at /Applications/Xcode.app/Contents/Developer ! Flutter recommends a minimum Xcode version of 13. Download the latest version or update via the Mac App Store. • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.21.0 [✓] Connected device (5 available) • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 11 (API 30) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 14.4.1 18D61 • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator) • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.4 19E2269 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.80 [✓] HTTP Host Availability • All required HTTP hosts are available ! Doctor found issues in 1 category. [!] Flutter (Channel master, 3.22.0-18.0.pre.53, on macOS 12.2.1 21D62 darwin-x64, locale en-GB) • Flutter version 3.22.0-18.0.pre.53 on channel master at /Users/dhs/documents/fluttersdk/flutter ! Warning: `flutter` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. ! Warning: `dart` on your path resolves to /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter. Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path. • Upstream repository https://github.com/flutter/flutter.git • Framework revision 098e7e7ff3 (4 hours ago), 2024-04-29 01:25:19 +0000 • Engine revision 752b146df7 • Dart version 3.5.0 (build 3.5.0-109.0.dev) • DevTools version 2.35.0-dev.16 • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [!] Android toolchain - develop for Android devices (Android SDK version 30.0.3) • Android SDK at /Users/dhs/Library/Android/sdk ✗ cmdline-tools component is missing Run `path/to/sdkmanager --install "cmdline-tools;latest"` See https://developer.android.com/studio/command-line for more details. ✗ Android license status unknown. Run `flutter doctor --android-licenses` to accept the SDK licenses. See https://flutter.dev/docs/get-started/install/macos#android-setup for more details. [✓] Xcode - develop for iOS and macOS (Xcode 13.2.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 13C100 • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2) • IntelliJ at /Applications/IntelliJ IDEA.app • Flutter plugin version 65.1.4 • Dart plugin version 213.7228 [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.29.0 [✓] Connected device (3 available) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 15.3.1 19D52 • macOS (desktop) • macos • darwin-x64 • macOS 12.2.1 21D62 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 109.0.5414.119 [✓] Network resources • All expected network resources are available. ! Doctor found issues in 1 category. [!] Xcode - develop for iOS and macOS (Xcode 12.3) • Xcode at /Applications/Xcode.app/Contents/Developer ! Flutter recommends a minimum Xcode version of 13. Download the latest version or update via the Mac App Store. • CocoaPods version 1.11.2 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] VS Code (version 1.62.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.21.0 [✓] Connected device (5 available) • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 11 (API 30) • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios • iOS 14.4.1 18D61 • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729 • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator) • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.4 19E2269 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 98.0.4758.80 [✓] HTTP Host Availability • All required HTTP hosts are available ! Doctor found issues in 1 category. ```
QuncCccccc commented 1 week ago

Thanks for filing this issue! The default searching algorithm is to find the first matching item which contains the queried text. We can use searchCallback to find the result exactly matching the query:) https://api.flutter.dev/flutter/material/DropdownMenu/searchCallback.html