search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
163.15k stars 26.86k forks source link

[CP] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage #149771

Open jonahwilliams opened 1 month ago

jonahwilliams commented 1 month ago

Issue Link

flutter/flutter#148213

Target

stable

PR Link

https://github.com/flutter/engine/pull/53235

Changelog Description

Impacted Users

Impeller on iOS

Impact Description

Rendering appears correct when BlendMode greater than screen is used.

Workaround

Use Skia

Risk

low

Test Coverage

yes

Validation Steps

Run attached tests.

zanderso commented 6 days ago

cp lgtm

itsjustkevin commented 5 days ago

https://github.com/flutter/engine/pull/53235/ merged