search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
164.62k stars 27.13k forks source link

Fix local testing, gradle XML errors, and enable on CI. #152383

Closed matanlurey closed 1 month ago

matanlurey commented 1 month ago

TIL you cannot have XML comments before the initial <?xml declaration.

Follow-up to https://github.com/flutter/flutter/pull/152326.

matanlurey commented 1 month ago

Unfortunately due to our CI setup I've spent all day trying to debug why this passes on CI (it shouldn't - a Skia Gold image should have been prompted for review). Hopefully this runs again today, if not I'll take it up again next week.

flutter-dashboard[bot] commented 1 month ago

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152383 at sha 095cf2416cc11d1b67251c537ba2b073859a8cdf

matanlurey commented 1 month ago

I need to tweak the ADB settings in order to hide this confirmation dialog:

image

flutter-dashboard[bot] commented 1 month ago

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152383 at sha 14207e996e551bf6158bd24ff96df86310ddb227

matanlurey commented 1 month ago

Looks like that wasn't sufficient, guess I'll try again tomorrow.

jonahwilliams commented 1 month ago

Is it possible to use Flutter's SystemChrome API to have the test app enable full screen and/or hide the status bar?

matanlurey commented 1 month ago

Is it possible to use Flutter's SystemChrome API to have the test app enable full screen and/or hide the status bar?

Hiding the bar is done, the problem is telling ADB "it's cool, I know it's hidden" for the screenshot

flutter-dashboard[bot] commented 1 month ago

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152383 at sha 78fd371f68826fc98c63f0bb34aa4b072bcbf2e1

flutter-dashboard[bot] commented 1 month ago

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152383 at sha 61382fcd088e285549c28a7e8c6f5b53a1465961

flutter-dashboard[bot] commented 1 month ago

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152383 at sha 27238f4ed8aa12b5e6fc52dd3db71da99a30d008