Closed qwertylolman closed 3 days ago
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I don't understand why there was a ClipRect, but it definitely breaks the appearance of the Dissmissible background.
UPD: ah, now I get it xD ok, is there any place where I could talk about the fix? as less effort and less impact solution I propose to pass Clip value from Dismissible ctor (smth like 'backgroundClip') so there will be a way to override the behavior. or some kind of builder function for background?
You can discuss this on our discord channel, see https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md.
Also, can you please add tests to this PR as instructed by the bot message above? Thank you.
Thanks for this, think I will create my own custom widget until this is merged
(triage) @qwertylolman Do you still have plans to get back to this PR?
(triage) @qwertylolman Do you still have plans to get back to this PR?
I am closing this PR. New PR with better solution will be created when I will have more time :/
Before
After
This PR fixes the issue 'Background Clipping in Dismissible #56812'
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.