`total_ui_gc_time:dynamic_path_tessellation_perf_ios__timeline_summary` 46% regression - Githubissues

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

https://flutter.dev

BSD 3-Clause "New" or "Revised" License

164.97k stars 27.18k forks source link

`total_ui_gc_time:dynamic_path_tessellation_perf_ios__timeline_summary` 46% regression #155259

Open gaaclarke opened 2 days ago

gaaclarke commented 2 days ago

There has been a regression in total_ui_gc_time introduced in https://github.com/flutter/flutter/pull/155194.

dashboard

https://flutter-flutter-perf.skia.org/e/?keys=Xc1b21aeae1d1cb98303548111d2f8ac3&selected=commit%3D42577%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253Dtotal_ui_gc_time%252Ctest%253Ddynamic_path_tessellation_perf_ios__timeline_summary%252C&xbaroffset=42577

gaaclarke commented 2 days ago

@flar do you think https://github.com/flutter/engine/pull/55125/files may have caused this? I know we didn't change dart code but we did modify some of the c++ code for dart:ui.