flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
165.7k stars 27.36k forks source link

[skwasm] Failed cherry pick for `Fix platform view placement` #155417

Open Rexios80 opened 1 month ago

Rexios80 commented 1 month ago

Cherry-pick issue: https://github.com/flutter/flutter/issues/154345

This cherry pick does not seem to have applied properly. Either that or it depends on other changes from master that also need cherry picked. I confirmed multiple times that this issue is still present in Flutter stable 3.24.3 but not master.

Steps to reproduce:

  1. Be in the camera plugin example: https://github.com/flutter/packages/tree/main/packages/camera/camera/example
  2. Be on Flutter version 3.24.3
  3. Run flutter run -d chrome --wasm
  4. Observe the bad platform view placement
  5. Be on Flutter master
  6. Run flutter run -d chrome --wasm
  7. Observe the correct platform view placement

cc @eyebrowsoffire

danagbemava-nc commented 1 month ago

Reproducible using the camera code sample app, only on stable.

stable master
Screenshot 2024-09-20 at 7 34 41 AM Screenshot 2024-09-20 at 7 35 27 AM
flutter doctor -v ``` [✓] Flutter (Channel stable, 3.24.3, on macOS 15.0 24A335 darwin-arm64, locale en-US) • Flutter version 3.24.3 on channel stable at /Users/deanli/dev/stable • Upstream repository https://github.com/flutter/flutter.git • Framework revision 2663184aa7 (8 days ago), 2024-09-11 16:27:48 -0500 • Engine revision 36335019a8 • Dart version 3.5.3 • DevTools version 2.37.3 ``` ``` [!] Flutter (Channel master, 3.26.0-1.0.pre.167, on macOS 15.0 24A335 darwin-arm64, locale en-US) • Flutter version 3.26.0-1.0.pre.167 on channel master at /Users/deanli/dev/master • Upstream repository https://github.com/flutter/flutter.git • Framework revision 1095351700 (4 hours ago), 2024-09-19 23:50:24 -0400 • Engine revision f5310c2345 • Dart version 3.6.0 (build 3.6.0-268.0.dev) • DevTools version 2.40.0-dev.1 ```