search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
164.79k stars 27.16k forks source link

PageTransitionsTheme needs to account for transition duration as well #29068

Open xster opened 5 years ago

xster commented 5 years ago

Currently MaterialPageRoute is just hardcoded to have a transition duration of 300ms and CupertinoPageRoute, 400ms. A MaterialPageRoute using CupertinoPageTransitionsBuilder via PageTransitionsTheme uses the wrong time duration.

cc @HansMuller

pedromassangocode commented 4 years ago

On the current dev channel the PageTransitionsTheme doesn't account for the transition duration accordingly to his contructor:

https://github.com/flutter/flutter/blob/1840b7121a6a721484afca300265c7866e82dc77/packages/flutter/lib/src/material/page_transitions_theme.dart#L563-L570

I was able to reproduce this in 1.21.0-1.0.pre.

flutter doctor -v ``` [✓] Flutter (Channel dev, 1.21.0-1.0.pre, on Mac OS X 10.15.5 19F101, locale en-AO) • Flutter version 1.21.0-1.0.pre at /Users/pedro/dev/SDKs/flutter_dev • Framework revision f25bd9c55c (2 days ago), 2020-07-14 20:26:01 -0400 • Engine revision 99c2b3a245 • Dart version 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0) • Android SDK at /Users/pedro/Library/Android/sdk • Platform android-30, build-tools 30.0.0 • Java binary at: /Users/pedro/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 11.5) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 11.5, Build version 11E608c • CocoaPods version 1.9.3 [✓] Chrome - develop for the web • CHROME_EXECUTABLE = /Applications/Google Chrome.app/Contents/MacOS/google-chrome-unsafe [✓] Android Studio (version 4.0) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 47.1.2 • Dart plugin version 193.7361 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [✓] Android Studio (version 4.0) • Android Studio at /Users/pedro/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents • Flutter plugin version 47.1.2 • Dart plugin version 193.7361 • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593) [✓] VS Code (version 1.47.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.12.1 [✓] Connected device (4 available) • AOSP on IA Emulator (mobile) • emulator-5554 • android-x86 • Android 9 (API 28) (emulator) • macOS (desktop) • macos • darwin-x64 • Mac OS X 10.15.5 19F101 • Web Server (web) • web-server • web-javascript • Flutter Tools • Chrome (web) • chrome • web-javascript • Google Chrome 83.0.4103.116 • No issues found! ```
danagbemava-nc commented 1 year ago

The code hasn't changed since https://github.com/flutter/flutter/issues/29068#issuecomment-659985200

https://github.com/flutter/flutter/blob/1840b7121a6a721484afca300265c7866e82dc77/packages/flutter/lib/src/material/page_transitions_theme.dart#L563-L570