keyonghan
commented
4 years ago The increased release branches may increase the github API requests. PR: https://github.com/flutter/cocoon/pull/795 removed one unused branch. More to come.
Closed godofredoc closed 4 years ago
keyonghan
commented
4 years ago The increased release branches may increase the github API requests. PR: https://github.com/flutter/cocoon/pull/795 removed one unused branch. More to come.
keyonghan
commented
4 years ago Moving the conversation about filtering out release branches here.
One possible way is to add more accurate regexps here: https://github.com/flutter/cocoon/blob/master/app_dart/dev/branch_regexps.txt
Instead of using general ^flutter-[0-9]+\.[0-9]+-candidate\.[0-9]+$, we use more accurate ones like '^flutter-1+.17+-candidate.3+$'. Whenever new release branch is created, we need to update this file as well. The same when we decide to skip branches.
Another way is keep the above file as it is, and simply add a new file which keeps track of all unwanted branches. Again, it needs to be updated when we decide to skip branches.
Both cases will face the same issue when the wanted branches keep accumulating in the long run. If some day the wanted branch number hit a threshold where the Github API requests already hit the limit, it would be a problem.
So the ideal case is that we keep track of a limited number of release branches.
/cc @godofredoc @pcsosinski
pcsosinski
commented
4 years ago FYI I'm working on a proposal that will reduce the number of branches we create.
Piinks
commented
4 years ago I've recently seen this show up once on the gold checks cocoon runs. Since the gold check is kinda moot on branches other than master we could make a reduction there.
pcsosinski
commented
4 years ago @christopherfujino may have created an issue for removing gold checks on release branches
christopherfujino
commented
4 years ago Instead of using general
^flutter-[0-9]+\.[0-9]+-candidate\.[0-9]+$, we use more accurate ones like '^flutter-1+.17+-candidate.3+$'. Whenever new release branch is created, we need to update this file as well. The same when we decide to skip branches.
We already have to update regexes in flutter/infra for each beta/stable release, as documented in the wiki, so we could add a step to update a file in cocoon.
godofredoc
commented
4 years ago Thank you all for the information keeping only the current branches in the file sounds like a very good short term solution. Ideally if we only keep <10 branches we can directly add the branch names and we don't need to call the github apis at all.
@christopherfujino do you have at hand the bug to remove gold checks from branches?
christopherfujino
commented
4 years ago @christopherfujino do you have at hand the bug to remove gold checks from branches?
I had not previously created the issue, so I created one now: https://github.com/flutter/flutter/issues/58814
pcsosinski
commented
4 years ago sgtm
keyonghan
commented
4 years ago With using hardcode branches instead of regexp, we didn't hit the rate limit error for the past two hours. Closing it for now.
github-actions[bot]
commented
3 years ago This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
GitHub Error: API rate limit exceeded for user ID 52682268.