search

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
166.24k stars 27.5k forks source link

Jump to today on date picker #72998

Open vendelin8 opened 3 years ago

vendelin8 commented 3 years ago

Use case

I'm running showDatePicker.

Proposal

It would be awesome to have a "Jump to Today" or similar button. So if I go to other month pages, I could get back in a single click.

justinmc commented 3 years ago

CC @darrenaustin

viralkachhadiya commented 3 years ago

hello, i am working on it.

justinmc commented 3 years ago

Thanks! I've assigned you.

viralkachhadiya commented 3 years ago

Please check the code and review my code. I pushed the code.

viralkachhadiya commented 3 years ago

https://user-images.githubusercontent.com/58855915/103287770-5bc91d00-4a09-11eb-9c1f-cb4ee487ae9c.mp4

justinmc commented 3 years ago

Where is your code at? Could you link to the PR?

viralkachhadiya commented 3 years ago

i think below link

https://github.com/flutter/flutter/pull/73101

viralkachhadiya commented 3 years ago

@justinmc @darrenaustin @PixelToast @tadaspetra @vendelin8

Please check below my PR link and give review for code.

https://github.com/flutter/flutter/pull/73101

viralkachhadiya commented 3 years ago

I cange some code clean up and clear autoformating tool .

@justinmc @darrenaustin @PixelToast @tadaspetra @vendelin8

Please review on below PR link

https://github.com/flutter/flutter/commit/f70a7f72eb01ccf1f8c79cb55c3db91e38a3f2d1

vendelin8 commented 3 years ago

That's only a commit. Your PR already has those formatting changes https://github.com/flutter/flutter/pull/73101

viralkachhadiya commented 3 years ago

That's only a commit. Your PR already has those formatting changes #73101

So, how to change pr with this commit

vendelin8 commented 3 years ago

If this does the job, then you should revert the earlier commits. Or commit code to rechange the original state. When you open the PR, on the files tab you can check the overall change you want to merge in the PR.

viralkachhadiya commented 3 years ago

Hello ,

I reset the pr request .please check it. @justinmc @darrenaustin @PixelToast @tadaspetra @vendelin8

https://github.com/flutter/flutter/pull/74377

vendelin8 commented 3 years ago

Looks good to me. I didn't approve it, because I'm not a flutter contributor, let's wait for someone closer to the project. Thanks Viral.

viralkachhadiya commented 3 years ago

@darrenaustin

please review my new above PR request

viralkachhadiya commented 3 years ago

@PixelToast @TahaTesser

Can you help about my this pull request?? Please provide some guidline so I will completed it.

https://github.com/flutter/flutter/pull/74377

viralkachhadiya commented 3 years ago

@vendelin8

Can you reassign me? Because I unassigned it by my mistake

vendelin8 commented 3 years ago

@viralkachhadiya I looked all the buttons, but I think I don't have permission to assign you.

viralkachhadiya commented 3 years ago

@vendelin8

Can you reassign me? Because I unassigned it by my mistake

@justinmc

justinmc commented 3 years ago

Sorry I missed these notifications. @viralkachhadiya do you still plan to work on this? If so I can reassign.

shubham3246 commented 10 months ago

@justinmc Can i work on this?

justinmc commented 10 months ago

@shubham3246 That would be great, thanks! I've assigned you. Take a look at the previous attempt at a PR (https://github.com/flutter/flutter/pull/74377) if you haven't already.

theadityaagnihotri commented 10 months ago

Hey , I want to work on this, can you please assign it to me? @justinmc

justinmc commented 10 months ago

@shubham3246 Looks like you have first dibs, are you still planning to open a PR for this or should I pass it to @theadityaagnihotri?

shubham3246 commented 10 months ago

@justinmc Yeah i think its gonna take a while, so you can pass it to the other person. I'll contact again when i complete the work.

flutter-triage-bot[bot] commented 4 months ago

This issue is assigned to @shubham3246 but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

flutter-triage-bot[bot] commented 1 month ago

This issue was assigned to @shubham3246 but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed.