flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond
https://flutter.dev
BSD 3-Clause "New" or "Revised" License
164.54k stars 27.13k forks source link

[cupertino] Update `CupertinoButton` & `CupertinoNavigationBar` documentation #91715

Open TahaTesser opened 2 years ago

TahaTesser commented 2 years ago

More details in https://github.com/flutter/flutter/pull/91602#pullrequestreview-777815883

A new CupertinoButton constructor for this special case may not be warranted since it's only setting the padding and minSize defaults. The docs already call out that the padding will need to be different in a CupertinoNavigationBar and it's not clear the extra constructor adds much over documentation.

Instead, we could extend the documentation on CupetinoButton.padding and CupertinoNavigationBar.leading to include a doc snippet to make it more likely that people will see it in the right context.

flutter-triage-bot[bot] commented 1 year ago

This issue is missing a priority label. Please set a priority label when adding the triaged-design label.