search

flutter / flutter_clock

BSD 3-Clause "New" or "Revised" License
543 stars 328 forks source link

Screen size #24

Closed jfdeveloper92 closed 4 years ago

jfdeveloper92 commented 4 years ago

Does the clock need to be adaptive to screen size? I know it needs to be 5:3.

colinskow commented 4 years ago

The 5:3 limitation imposed by ClockCustomizer does look really ugly on widescreen devices. Can we remove this or make it an optional setting? I'd prefer to make a responsive landscape clock that looks good at 5:3 and other aspect ratios as well.

Also, things would look a lot better if ClockCustomizer hides the status bar and enforces landscape view.

jfdeveloper92 commented 4 years ago

I do think the reason the 5:3 aspect ratio is required is because the Lenovo clocks for this contest is a 5:3 I could be wrong I'm not exactly sure what the aspect ratio is I'm just assuming that based on the contest description.

colinskow commented 4 years ago

My question is, do we need to use the forced 5:3 from the starter repo, or is it okay to remove that and allow it to be responsive on various aspect ratios?

jfdeveloper92 commented 4 years ago

I could be mistaken but I believe the reason 5:3 aspect ratio is required is because the Lenovo clock and smart display probably has a 5:3 ratio

jkurtw commented 4 years ago

It will only be judged with 5:3 aspect ration, but if it looks good with others, that's great!