search

flutter / flutter_clock

BSD 3-Clause "New" or "Revised" License
543 stars 328 forks source link

Two pixels border on customizer.dart #35

Closed ma-altaiir closed 4 years ago

ma-altaiir commented 4 years ago

If we try to pixel perfect fill a container with tiles inside the 5/3 aspect ratio, there will be an overflow since customizer.dart contains a 2.0 pixels border. @override Widget build(BuildContext context) { final clock = Center( child: AspectRatio( aspectRatio: 5 / 3, child: Container( decoration: BoxDecoration( border: Border.all( width: 2, color: Theme.of(context).unselectedWidgetColor, ), ), child: widget._clock(_model), ), ), );

Can we change that one or please change it and make container background grey for visibility instead of a border.

orgil1230 commented 4 years ago

yeah i've deleted the border already. Is it fine ?

jkurtw commented 4 years ago

Yes, feel free to remove the border.