Tidy up - Githubissues

flutter / put-flutter-to-work

A Flutter add-to-app demo you can try with your own apps

BSD 3-Clause "New" or "Revised" License

321 stars 38 forks source link

Tidy up #170

Closed domesticmouse closed 1 year ago

domesticmouse commented 1 year ago

Bringing repo up to current versions

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[x] 🗑️ Chore

parlough commented 1 year ago

Maybe don't include the pubspec.lock file for the packages under put-flutter-to-work/flutter_nps/packages?

parlough commented 1 year ago

I didn't realize it would auto merge with the checks still failing. Sorry!

domesticmouse commented 1 year ago

We need to configure the tests as required, I'm guessing

domesticmouse commented 1 year ago

Should we revert this and single step?

parlough commented 1 year ago

I think it's fine since the tests passed on https://github.com/flutter/put-flutter-to-work/pull/172

miquelbeltran commented 1 year ago

Hey! Looks like this PR broke the app, look at the changed done on bootstrap.dart. The call to runApp was removed, which causes the Flutter module to hang on start.

I'll prepare a PR to fix it.