re-add runApp, call recyclerView.post to notify the adapter 1 frame after the update

flutter / put-flutter-to-work

A Flutter add-to-app demo you can try with your own apps

BSD 3-Clause "New" or "Revised" License

321 stars 38 forks source link

re-add runApp, call recyclerView.post to notify the adapter 1 frame after the update #195

Closed elainedb closed 1 year ago

elainedb commented 1 year ago

re-add runApp (maybe it was removed after a refactoring :)), call recyclerView.post to notify the adapter 1 frame after the update

Description

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

miquelbeltran commented 1 year ago

Hi @elainedb I tested your PR because current main is broken, but I couldn't make it work either. After scrolling at the bottom, the Flutter view doesn't load for me.

I recorded a video of it.

https://user-images.githubusercontent.com/2494376/228572930-c123001a-18b5-4269-8f3f-c79c402e4d1d.mp4

domesticmouse commented 1 year ago

Hey @elainedb please resolve the conflicts and work with @miquelbeltran to get this PR working. Thank you!

RedBrogdon commented 1 year ago

I'm going to go ahead and close this, since elainedb hasn't had time to come back to it. I believe the runApp call was restored by #210.