feat: native ios counter app

flutter / put-flutter-to-work

A Flutter add-to-app demo you can try with your own apps

BSD 3-Clause "New" or "Revised" License

321 stars 38 forks source link

feat: native ios counter app #55

Closed Jan-Stepien closed 2 years ago

Jan-Stepien commented 2 years ago

Description

Implementation of ios native counter app with opening Flutter module

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[x] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

Jan-Stepien commented 2 years ago

I was focused on having app up and running with the GitHub pipeline I wasn't paying attention to swift code, as the app is going to be rewritten into NewsfeedApp ( its back in scope).

Xcode doesn't have default formatter ( just indentations ) and im not iOS dev to decide on one, but I will try to stay consistent.

Obv code stays, so i should take care of it- will pay better focus to natives when I implement them.

felangel commented 2 years ago

I was focused on having app up and running with the GitHub pipeline I wasn't paying attention to swift code, as the app is going to be rewritten into NewsfeedApp ( its back in scope).

Xcode doesn't have default formatter ( just indentations ) and im not iOS dev to decide on one, but I will try to stay consistent.

Obv code stays, so i should take care of it- will pay better focus to natives when I implement them.

Regarding formatting we can use https://github.com/apple/swift-format.