search

flutter / samples

A collection of Flutter examples and demos
https://flutter.github.io/samples/
Other
17.04k stars 7.49k forks source link

Embed image assets in the material demo – to avoid CORS issues #1844

Closed kevmoo closed 1 year ago

kevmoo commented 1 year ago

image

See https://flutterweb-wasm.web.app/#/ – 

kevmoo commented 1 year ago

CC @domesticmouse @johnpryan

johnpryan commented 1 year ago

I don't think it's a CORS issue, it looks like these URLs are broken, but I agree we should remove the dependency on https://github.com/flutter/assets-for-api-docs

The correct links should have/blob/main and ?raw=true, for example https://github.com/flutter/assets-for-api-docs/blob/main/assets/material/content_based_color_scheme_1.png?raw=true

kevmoo commented 1 year ago

FYI: also here - https://flutter.github.io/samples/web/material_3_demo/#/

Maybe GitHub changed some config? Or did we stop publishing something?

johnpryan commented 1 year ago

Disregard my previous comment, we need to get the GitHub Pages hosting for the assets-for-api-docs repo working again. We need https://flutter.github.io/assets-for-api-docs/assets/material/content_based_color_scheme_1.png to return the image, since they need to be the same domain for CORS.

cc: @QuncCccccc @gspencergoog

gspencergoog commented 1 year ago

Yes, working on it.

QuncCccccc commented 1 year ago

Looks like the images are back! 🎉 https://flutter.github.io/samples/web/material_3_demo/#/

gspencergoog commented 1 year ago

Yeah, Godofredo updated the settings, so it's back.