search

flutter / samples

A collection of Flutter examples and demos
https://flutter.github.io/samples/
Other
17.04k stars 7.49k forks source link

Web-specific issues with "Material 3 - Flutter WasmGC Preview" #2069

Closed tomayac closed 8 months ago

tomayac commented 10 months ago

Tested on 120.0.6089.3 (Official Build) canary (arm64).

parlough commented 10 months ago

Thanks for the videos showcasing the issues!

Just to confirm, did you access the sample at https://flutterweb-wasm.web.app/, somewhere your else, or build it yourself with a recent Flutter build? On Chrome 120 I'm only able to get the WASM sample running by building myself with the latest Flutter main builds.

I think outside of the text editing issues, these issues exist in some form on the JS version of the demo too. \cc @QuncCccccc

I can't seem to reproduce the text editing issues on the JS version nor by building myself on the latest main on Version 120.0.6090.1 (Official Build) canary (arm64).

\cc @kevmoo

tomayac commented 10 months ago

This was tested with the URL you can find in this Google Doc. Please ask for access, since it's not yet public.

kevmoo commented 10 months ago

We should compare with https://flutter.github.io/samples/web/material_3_demo/

To see if these are issues with the Wasm work, or just issues with the demo/widgets!

parlough commented 10 months ago

Thanks for the link! Clarifying for the issue that these videos are with skwasm.

I can reproduce the scrolling and tabbing issues with the original JS version.

The popover behavior does seem to have more issues in the linked version and the text editing issues are unique to this version as well. They don't occur on a wasm build with CanvasKit either.

tomayac commented 10 months ago

All videos and reported issues stem from the version linked in the Google Doc experienced in 120.0.6089.3 (Official Build) canary (arm64).

domesticmouse commented 10 months ago

Who should I assign this issue to?

kevmoo commented 10 months ago

@domesticmouse – we need to figure out if this is a widget issue or a flutter wasm issue.

So...I'm not sure. It'd be great to have our flutter/flutter triage person take a stab.

QuncCccccc commented 10 months ago

Hi!

The scrolling behavior is intended. We compute the scroll bar height when more content shows up for the first time and cache the height. So after that, the scroll bar height should be fixed!

I can reproduce the popover positioning problem. I think it's a widget issue. I will take a look:) !

For the other two issues, I cannot reproduce them.

domesticmouse commented 9 months ago

@kevmoo assigning this to you to chase down the issues @QuncCccccc can't repro

parlough commented 8 months ago

Closing in favor of https://github.com/flutter/samples/issues/2129, where I'm tracking this and other issues more specifically. Thanks all!