Closed eliasyishak closed 1 year ago
@jayoung-lee whenever you get a chance to review, this PR will essentially ensure that future updates to the context survey json will be valid and won't break package:unified_analytics
As for the analysis question:
I would probably add it as a separate job in the same file, so it doesn't ever block the actual validation. Would something like this work?
analyze:
runs-on: ubuntu-latest
defaults:
run:
working-directory: surveys/validator
steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
- uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
- name: Verify formatting
run: dart format --output=none --set-exit-if-changed .
- name: Analyze Dart files
run: dart analyze --fatal-infos
I accidentally deleted your comment. I'm so sorry...I meant to delete one of mine. 🙇
Thanks for addressing my comments, I appreciate it!
As for the analysis question:
I would probably add it as a separate job in the same file, so it doesn't ever block the actual validation. Would something like this work?
analyze: runs-on: ubuntu-latest defaults: run: working-directory: surveys/validator steps: - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 - uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f - name: Verify formatting run: dart format --output=none --set-exit-if-changed . - name: Analyze Dart files run: dart analyze --fatal-infos
Yep! This seems to work as expected, and looks like both jobs ran in my latest commit
Reference issue:
This will add validation for the json file to ensure the data is correct
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.