flutter / uxr

UXR work for Flutter
BSD 3-Clause "New" or "Revised" License
227 stars 28 forks source link

Auto Route First 2 Scenarios #36

Closed theweiweiway closed 3 years ago

theweiweiway commented 3 years ago

First 2 scenarios with Auto Route

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

theweiweiway commented 3 years ago

@googlebot I signed it!

theweiweiway commented 3 years ago

Open to suggestions and changes, especially from @Milad-Akarie

theweiweiway commented 3 years ago

@InMatrix would you like generated code in this as well?

InMatrix commented 3 years ago

@theweiweiway Thanks for the PR. No, I don't need the generated code.

johnpryan commented 3 years ago

Moving this here: https://github.com/flutter/uxr/pull/54

johnpryan commented 3 years ago

@theweiweiway this has been merged, but I was wondering if it was intentional that the detail page doesn't have a back button?