Add Qlevar Router code samples

SchabanBo commented 3 years ago

Here are the code snippets for qlevar_router. you can find them in qr_samples too.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

SchabanBo commented 3 years ago

@googlebot I signed it!

Hixie commented 2 years ago

@InMatrix Is this obsolete?

InMatrix commented 2 years ago

@SchabanBo Sorry about failing to review your contributions. If you're still interested in getting those samples merged into this repo, so others can compare Qlevar side by side with other routing packages, I'd happy to do a light review (i.e., checking the app behavior but not code quality). Otherwise, I'll close this PR. Please let me know by the end of the week.

SchabanBo commented 2 years ago

@InMatrix That would be great. Thanks

InMatrix commented 2 years ago

@SchabanBo The folder structure has changed since your PR was submitted. Could you sync with master and update this PR? Thanks!

SchabanBo commented 2 years ago

@InMatrix I have fixed these two issues and added the nested routing example. At the time I added the qlevar router examples. there was no router example for the nested routing. thanks for reminding

InMatrix commented 2 years ago

Thanks for updating the PR. I confirm that the bug in the skip stacks example has been fixed.

For the deep linking by path parameter example, I still don't see the in-app back button when going to a book page directly (see the screenshot below):

For the nested routing example, the tabs won't switch when the URL has changed after clicking the back button in the browser. I attached a screencast below:

https://user-images.githubusercontent.com/348942/139559003-d382bc78-f2f7-413f-a5ec-ec4ea6a2bb9f.mov

SchabanBo commented 2 years ago

@InMatrix sorry about that. I forgot to add the tab listener.

InMatrix commented 2 years ago

@johnpryan Do you know how to unblock this PR? It's blocked by a signing issue I'm not familiar with: "The base branch requires all commits to be signed."

johnpryan commented 2 years ago

I believe Flutter organization PRs require commits to be signed now. Pull request authors need to follow the steps described in the Commit signature verification page from the GitHub docs.

flutter / uxr