search

flutter / uxr

UXR work for Flutter
BSD 3-Clause "New" or "Revised" License
227 stars 28 forks source link

Navi 0.2.0 code snippets #44

Closed xuanswe closed 3 years ago

InMatrix commented 3 years ago

@nguyenxndaidev Is this PR ready for review? I can do a shallow review (i.e., checking whether the demos match the reference implementations in Navigator 2.0) and merge them.

xuanswe commented 3 years ago

@InMatrix yes, it's ready. Thanks for checking my PR.

InMatrix commented 3 years ago

Okay, I checked the behavior of the demos and found only 1 issue. The skipping stacks demo required me to click the browser's back button more than once to get back to the previous screen. Please see this screen recording:

https://user-images.githubusercontent.com/348942/116470067-c9eee680-a827-11eb-8c9f-31436b4087e4.mov

I'd be happy to merge the snippets as is with a TODO comment in skipping_stacks_navi.dart or wait until you fix this issue.

xuanswe commented 3 years ago

Hi @InMatrix, please wait for me to check it first if I can do a quick hotfix. Otherwise I'll let you know to merge without the fix. Thanks a lot for your time!

xuanswe commented 3 years ago

Hi, I fixed it locally. I am publishing version 0.2.1 with the hotfix now.

xuanswe commented 3 years ago

@InMatrix Fixed now. Could you please check again?