search

flutter / uxr

UXR work for Flutter
BSD 3-Clause "New" or "Revised" License
227 stars 28 forks source link

Beamer loses filter when URL is provided in the browser #69

Closed idkq closed 3 years ago

idkq commented 3 years ago

@slovnicki Do you mind checking it please

Filter is not working properly when URL is typed in the browser's navigation bar.

Repro `flutter run -d Chrome -t lib/deeplink-queryparam/deeplink-queryparam_beamer.dart --web-port=51513` Paste in browser bar and hit enter (TWICE - two times): http://localhost:51513/#/?filter=land http://localhost:51513/#/?filter=land (again) Filters disappears
Doctor [✓] Flutter (Channel beta, 2.2.2, on macOS 11.4 20F71 darwin-x64, locale en-US) [✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3) [✓] Xcode - develop for iOS and macOS [✓] Chrome - develop for the web [✓] Android Studio (version 4.1) [✓] IntelliJ IDEA Ultimate Edition (version 2021.1.2) [✓] Connected device (2 available) • No issues found!
slovnicki commented 3 years ago

@idkq Thanks for noticing this! I was unintentionally ignoring query parameters on initial route path /. It's fixed now and will be released in v0.14.1; https://github.com/slovnicki/beamer/commit/c6ad949996e05a5b0b25ea5f492acbb011a4c2e6