flutter / website

Flutter documentation web site
https://docs.flutter.dev
Other
2.82k stars 3.22k forks source link

Update associated domains instructions on 'Set up universal links for iOS' page #10111

Open oodavid opened 9 months ago

oodavid commented 9 months ago

Page URL

https://docs.flutter.dev/cookbook/navigation/set-up-universal-links/

Page source

https://github.com/flutter/website/tree/main/src/cookbook/navigation/set-up-universal-links.md

Describe the problem

When using xcode to add the associated-domains only ios/Runner/RunnerRelease.entitlements is updated - when developing, we also need to adjust ios/Runner/Runner.entitlements.

Expected fix

Don't recommend editing these values with xcode, instead recommend directly editing the config files:

With an additional note to check for other entitlement files for different release modes in the ios/Runner directory.

Additional context

Other pages in the docs recommend editing the config files directly (ie: not via xcode):

https://docs.flutter.dev/data-and-backend/networking#macos https://docs.flutter.dev/platform-integration/ios/ios-app-clip https://docs.flutter.dev/perf/impeller

milansurelia commented 5 months ago

Can I work on this and send a PR?

atsansone commented 5 months ago

Sure. I was looking into it, but happy to have the help @milansurelia

milansurelia commented 5 months ago

@atsansone I have updated the site content and attached an image. Could you please verify it?

PR1

PR2

milansurelia commented 4 months ago

@atsansone Have you checked the above screenshot? Is it correct?