search

flutter / website

Flutter documentation web site
https://docs.flutter.dev
Other
2.8k stars 3.21k forks source link

examples not linked in the examples catalog #1198

Closed Twinber closed 5 years ago

Twinber commented 6 years ago

There are many examples in the catalog/samples folder, but only four are linked at https://flutter.io/catalog/samples/

Why?

Sfshaza commented 5 years ago

@RedBrogdon, do you know anything about this?

RedBrogdon commented 5 years ago

That's the old listing of samples, which (as @Twinber pointed out) no longer reflects what we have going. The place to point people is the curated index:

https://github.com/flutter/samples/blob/master/INDEX.md

Sfshaza commented 5 years ago

Thanks, Andrew. I'll fix!

On Tue, Oct 9, 2018 at 12:54 PM Andrew Brogdon notifications@github.com wrote:

That's the old listing of samples, which (as @Twinber https://github.com/Twinber pointed out) no longer reflects what we have going. The place to point people is the curated index:

https://github.com/flutter/samples/blob/master/INDEX.md

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flutter/website/issues/1198#issuecomment-428328575, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAHwkhKiL3ahcfMWUxVyrbBE9KmAi_Gks5ujP8IgaJpZM4WQKFv .

Sfshaza commented 5 years ago

I misunderstood the problem before, and have a followup question:

Andrew, are these 4 samples linked to by your GitHub index? (I didn't see them.) If so, I'll remove this page from the repo.

RedBrogdon commented 5 years ago

Those samples are in the main flutter/flutter repo, so they're not part of our main "body of samples" so to speak.

(not that they can't teach people useful things or anything -- it's just that they're not the first thing I'd want to direct people to)

Sfshaza commented 5 years ago

Hmmm... It sounds like we should change the intro text on that page and link to our GitHub samples.

chalin commented 5 years ago

Given that the samples page is deprecated, should we just close this issue? Or is there a plan to update the samples? cc @kwalrath

RedBrogdon commented 5 years ago

Right now, my preference is that we just point people to the curated index in the samples repo at let that be it. One of the items on my Q1 todo list, though, is to come up with something more visual, similar to the old samples page in terms of visual content, but linking people to the samples created by DevRel.

I'd be only happy to take pointers from y'all about how to best work something like that into the site.

chalin commented 5 years ago

Right now, my preference is that we just point people to the curated index in the samples repo [and] let that be it.

Ok.

@sfshaza2 wrote:

It sounds like we should change the intro text on that page and link to our GitHub samples.

Let's do that.

chalin commented 5 years ago

One of the items on my Q1 todo list, though, is to come up with something more visual, similar to the old samples page in terms of visual content, but linking people to the samples created by DevRel.

Let's track that via #1923.

kwalrath commented 5 years ago

My proposed solution (in #1924) is to remove all content (except a link to the curated list) from /docs/catalog/samples, but to leave the samples underneath on the website, for now. We just won't point to them.

Sound OK, @RedBrogdon?

chalin commented 5 years ago

@InMatrix might want to chime in?

InMatrix commented 5 years ago

@Twinber Thank you for your issue report. We're in the process of revamping the samples catalog (https://flutter.io/catalog/samples/) to showcase newer samples in the https://github.com/flutter/samples repo. The work is currently scheduled in Q1 next year. In the meantime, would you rather not to see the deprecated samples catalog (as marked in the side nav) or you still find the page useful? Thanks!

kwalrath commented 5 years ago

If the four samples under flutter.io/catalog/samples might still be useful to someone, something we could do for now is add links from https://github.com/flutter/samples/blob/master/INDEX.md to those four samples. It could be something like this at the very bottom of the page:

Are you looking for the old Flutter samples? They're still available: [AnimatedList][], [AppBar with a custom bottom widget][], [AppBar basics][], [ExpansionTile][].

Where those are links to URLs like https://flutter.io/docs/catalog/samples/basic-app-bar.