flutter / website

Flutter documentation web site
https://docs.flutter.dev
Other
2.82k stars 3.23k forks source link

Migrate embedded DartPad editors away from multi-file #9898

Closed johnpryan closed 11 months ago

johnpryan commented 11 months ago

Describe the problem

We need to remove any content that uses DartPad's editable test code features so that they are ready to migrate to the new preview.dartpad.dev editor.

Expected fix

Pages that use embedded DartPads:

Pages that mention DartPad workshops:

On which platform(s) did you experience this issue?

No response

Additional context

See also: https://github.com/dart-lang/site-www/issues/5382

atsansone commented 11 months ago

@johnpryan : Could use some clarity for this issue. Do you want the embedded DartPad removed on these pages? If it appears on other pages, should we remove them there, too? With the pages that mention DartPad, we should remove the mention?

Thanks!

parlough commented 11 months ago

I think I've removed the remaining use cases of multi-file support already (on docs.flutter.dev), but if someone wants to double check, please do so!

The mentions to workshops will have to be removed though.

johnpryan commented 11 months ago

Tony, I shared the migration plan with you at go/dartpad-frontend-migration-plan.

I haven't verified that the test code features have been removed, so I filed this issue to be safe, but if none of them are using these features we should be fine to close this issue.

atsansone commented 11 months ago

That works. Thanks @johnpryan !

parlough commented 11 months ago

I'll do another pass to make sure and handle any other remaining uses and workshop mentions. Thanks for filing the issue John!