fluttercandies / extended_nested_scroll_view

extended nested scroll view to fix following issues. 1.pinned sliver header issue 2.inner scrollables in tabview sync issue 3.pull to refresh is not work. 4.do without ScrollController in NestedScrollView's body
MIT License
591 stars 117 forks source link

Tabs sync issue is not solved in versions 4.0 and 5.0 #89

Closed naamapps closed 2 years ago

naamapps commented 2 years ago

Hey, In versions before 4.0, the sync issue was fixed, but with the refractor in 4.0 something is not working there. I set onlyOneScrollInBody to true but the tabs still scrolls together sometimes. Even in the simple example in the demo website, you will find the sync bug there. Please help, Thanks.

zmtzawqlp commented 2 years ago

please provide runnable demo, i can't reproduce at my side

naamapps commented 2 years ago

Hey @zmtzawqlp, Here is a video of the issue, As you can see, there are 2 issues:

  1. When the second tab have a shorter list, and scrolling a little bit, the first tab also scrolls (sync issue - 00:07 in the video).
  2. At 00:42 in the video, you can see the header showed a bit even when we are not at the top of the first tabs list. This happens because the list in the second tab is at the top so the sync issue is not solved and it thinks that the header needs to show.

All this issues were not present in versions before 4.0. Unfortunately I can't share the code as its private. But I promise you it is like in the example.

Also sometimes I get this error:

══╡ EXCEPTION CAUGHT BY ANIMATION LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown while notifying listeners for AnimationController:
'package:extended_nested_scroll_view/src/extended_nested_scroll_view.dart': Failed assertion: line
1740 pos 9: 'result': is not true.

When the exception was thrown, this was the stack:
#2      _NestedOuterBallisticScrollActivity.applyMoveTo (package:extended_nested_scroll_view/src/extended_nested_scroll_view.dart:1740:9)
#3      BallisticScrollActivity._tick (package:flutter/src/widgets/scroll_activity.dart:553:10)

https://user-images.githubusercontent.com/37176893/133048051-0bbc4bfe-b481-4210-a1e5-557658f07295.mp4

popsams commented 2 years ago

Hey, In versions before 4.0, the sync issue was fixed, but with the refractor in 4.0 something is not working there. I set onlyOneScrollInBody to true but the tabs still scrolls together sometimes. Even in the simple example in the demo website, you will find the sync bug there. Please help, Thanks.

https://github.com/fluttercandies/extended_nested_scroll_view/issues/82 https://github.com/fluttercandies/extended_nested_scroll_view/issues/82

naamapps commented 2 years ago

@zmtzawqlp please let me know if there's something we can do.. There is no purpose in using this package if the sync issue is not resolved. Thanks

zmtzawqlp commented 2 years ago

@naamapps sorry, i can't reproduce at my side, please use old version if it is emergency for you. i will keep look into it.

b3nni97 commented 2 years ago

Does not work for me either with the last master version

popsams commented 2 years ago

可以的话根据3.0.1版本重新搞一下吧,3.0.1版本后版本都有异常,谢谢

zmtzawqlp commented 2 years ago

please provide runnable simple demo and steps to reproduce this issue.

popsams commented 2 years ago

demo代码和重现录屏之前已经提交过给你了,但是你之前说你那边不能重现,这个确实没办法,其他人也遇到类似问题,那应该是还有一些问题没解决

andychan06 commented 2 years ago

你好 請問這個問題解決了沒有?

popsams commented 2 years ago

你好 請問這個問題解決了沒有?

3.0.1版本正常,可能作者误打误撞3.0.1版本碰巧解决了,后面版本就不行了,越更新越拉跨

naamapps commented 2 years ago

I don't understand what the others wrote, but from my side the problem is not solved. Version 3 is perfect. @zmtzawqlp I hope you can find the issue.

zmtzawqlp commented 2 years ago

I don't understand what the others wrote, but from my side the problem is not solved. Version 3 is perfect. @zmtzawqlp I hope you can find the issue.

i can't reproduce at my side, i always wait someone can provide a simple runnable demo and clearly reproduce steps. you can use 3.0.0 version if it's emergency.

zmtzawqlp commented 2 years ago

Hey, In versions before 4.0, the sync issue was fixed, but with the refractor in 4.0 something is not working there. I set onlyOneScrollInBody to true but the tabs still scrolls together sometimes. Even in the simple example in the demo website, you will find the sync bug there. Please help, Thanks.

webdemo is build in old version, i can't get what do you mean it didn't work.

LeGoffMael commented 2 years ago

I confirm that with latest version 5.0.0 the issue 2:tabview sync issue is not solved. Works well on version 3

zmtzawqlp commented 2 years ago

please try 5.1.2 version

naamapps commented 2 years ago

@zmtzawqlp Can you please set the version of visibility_detector to be 0.3.3 (latest)? I can't upgrade because of version mismatch.

zmtzawqlp commented 2 years ago

@zmtzawqlp Can you please set the version of visibility_detector to be 0.3.3 (latest)? I can't upgrade because of version mismatch.

this is base on your sdk, it will 0.3.3 if you is in flutter 3.0.0

or you can override

dependency_overrides: visibility_detector: ^0.3.3

naamapps commented 2 years ago

I am on flutter 3.0. And can't upgrade because you used an old visibility detector version.. I can use dependancy override, but it's not recommended.. If you can upgrade to 0.3.3 it will be the best. Thanks

zmtzawqlp commented 2 years ago

i use 0.22 , so more people can use extended_nested_scroll_view. dependancy override is not bad thing

sed1ka commented 2 years ago

based on dart: depedencies, they warn about using dependencies_override

Warning: Using a dependency override involves some risk. For example, using an override to specify a version outside the range that the package claims to support, or using an override to specify a local copy of a package that has unexpected behaviors, may break your application.

I agree with @naamapps I think forcing the user to update the latest version of visibility_detector is not bad thing, than the risk that might occur when using dependencies_override. After all, one day we will have to use the latest version of the library (which has a lot of fixes and enhancements)

zmtzawqlp commented 2 years ago

close with https://github.com/fluttercandies/extended_nested_scroll_view/commit/029b0911cf3cfea57e8277e8a63429b26dc18aba

ItsManikantaGopi commented 1 year ago

please try 5.1.2 version

  • Provide ExtendedVisibilityDetector to point out which list is visible

I have tried 5.1.2, but still issue is not fixed!