search

fluttercandies / like_button

Like Button is a flutter library that allows you to create a button with animation effects similar to Twitter's heart when you like something and animation effects to increase like count.
MIT License
469 stars 96 forks source link

Fix Number reversed when using RTL localization. #59

Closed Danzo7 closed 2 years ago

Danzo7 commented 2 years ago

:information_source: Number always writen from Left to Right it does not matter if the text direction is RTL or LTR.

:bug: Bug:

zmtzawqlp commented 2 years ago

thanks your contribution. public textDirection: TextDirection.ltr as property will better.

Danzo7 commented 2 years ago

Hi @zmtzawqlp Hope you are doing great!

This will work too, but I would rather keep it like that as there is no language that read numerals from right to left so I don't think its make sense as property, Also we just use it to reverse back the row of numbers and having it as property that can cause conflict with the meaning of textDirection as we don't actually modify the direction of text , don't you agree?

zmtzawqlp commented 2 years ago

Hi @zmtzawqlp Hope you are doing great!

This will work too, but I would rather keep it like that as there is no language that read numerals from right to left so I don't think its make sense as property, Also we just use it to reverse back the row of numbers and having it as property that can cause conflict with the meaning of textDirection as we don't actually modify the direction of text , don't you agree?

ok, i got it, thanks