search

fluttercommunity / app_review

App Review - Request and Write Reviews and Open Store Listing for Android and iOS in Flutter. Maintainer: @rodydavis
https://fluttercommunity.github.io/app_review/
MIT License
329 stars 109 forks source link

app_review canLaunch("market://") won't work correctly #24

Closed techwn closed 3 years ago

techwn commented 4 years ago

I have test on app_review 1.0.0 I found code in app_review.dart like below won't work fine which will always lead android to open google play in browser.

if (await canLaunch("market://")) {// this always return false print('launching store page'); await launch("market://details?id=" + _appID); details = 'Launched App Store Directly: $_appID'; } else {// so we always run in else, await launch("https://play.google.com/store/apps/details?id=" + _appID); details = 'Launched App Store: $_appID'; }

I changed the url from market:// to market://details which is used in brace, then it works fine.

And I find this keep the same in latest version of 1.1.0+1.

rodydavis commented 4 years ago

Please submit a PR and i will be happy to publish!

maddyb99 commented 3 years ago

Is this issue solved or WIP?

shinsenter commented 3 years ago

@T-mans @maddyb99 This may be resolved with No #38.