kalismeras61 commented 4 years ago

Package Proposal: page_transition

Dependency name (as used in pubspec.yaml): page_transition Current pub.dev link: https://pub.dev/packages/page_transition Current Git repository link: https://github.com/kalismeras61/flutter_page_transition Description: When you go to next page this package gives you beautiful page transitions. Current maintainer: Yasin Ilhan, yasinilhan61@gmail.com, kalismeras61 Needs new maintainer after transfer: NO New maintainer (if applicable): Reason for transfer: This package is that allows you nice transition when you go to next page and also it is first easy to use package with 99 score and peoples love. Comments:

jeroen-meijer commented 4 years ago

Hi there,

Thanks for the package proposal. Due to recent events within the community and the world overall, we're currently quite busy and will not be able to respond to most package proposals and other community inquiries on GitHub as well as you might expect. Sorry about that. We'll keep you up to date.

Thank you for understanding.

Best regards, Jay (Flutter Community GitHub admin).

jeroen-meijer commented 4 years ago

Hi there,

Thanks again for submitting your package. It looks nice!

I've tested the package on an iPhone 11 Pro Max simulator, reviewed the codebase and have found the following issues, sorted by importance.

To do before approval

As soon as these issues are fixed, the package will get rereviewed and added to the Flutter Community.

Documentation. The documentation is either missing, improperly formatted (using // instead of ///) or contains slightly incorrect spelling or grammar (such as missing periods). Please ensure all classes and fields have proper documentation. (Check the Dart doc guide for reference.) To see which parts are missing, try adding analysis_options.yaml file to the root of the project (next to lib, pubspec.yaml, etc.) with the following code. Then, either use your IDE or run flutter analyze and fix all issues/warnings.

linter:
  rules:
    - public_member_api_docs
    - package_api_docs
    - slash_for_doc_comments

Curve inconsistencies in the library. Not all transitions use the curve that's given to a PageTransition instance, which makes for inconsistent behaviour between transitions. Please make sure all transitions used the provided curve.
Missing transitions in the example. In the example, some buttons don't show the right page transition. For example, the "Down to Up Second Page" doesn't seem to use the package at all, but just pushes a new route using the Navigator.pushNamed. The transition that's played doesn't go from the bottom to the top, but rather zooms from the top-left of the screen. Please make sure all transitions have a properly working button in the example.
Formatting inconsistencies in the example. The example project has inconsistent formatting. For example, some pieces of code arre written using trailing comma's, which is preferred, but some don't. Please make the formatting of the example project consistent.

Changes for the future

These are changes that aren't required now but would be nice to have in the future, either by you or another community member.

Clarifying some transitions (BREAKING). There are two transitions, upToDown and downToUp that might be more approriately named topToBottom and bottomToTop. Please consider adding the last two enum values and deprecating the first two. Then you can remove the older two at a later date.

Please make these changes and tell me when you've done so in this issue. If you have any questions, don't hesitate to ask. 👍🏻

Best regards.

jeroen-meijer commented 4 years ago

Hi there @kalismeras61 👋🏻

Are there any updates to this? 😄

kalismeras61 commented 4 years ago

Hi @jeroen-meijer , i think everything is done with Page Transition 1.1.7

jeroen-meijer commented 4 years ago

Hi there @kalismeras61

LGTM

Approved

Thanks for submitting this package. It has been reviewed and approved for release on the Flutter Community GitHub! 🎉 Great work. 👍🏻

What to do next

Please follow steps 3 through 7 in the Flutter Community Transfer Guide and let me know when you're done.

Good luck! 👋🏻

jeroen-meijer commented 3 years ago

Closing this due to inactivity. Feel free to reopen again.

fluttercommunity / community