JonathanMonga commented 4 years ago

Package Proposal: flutter_gradients

Dependency name (as used in pubspec.yaml): flutter_gradients Current pub.dev link: https://pub.dev/packages/flutter_gradients Current Git repository link: https://github.com/JonathanMonga/flutter_gradients Description: A curated collection of awesome gradients made in Dart for Flutter. Current maintainer: Jonathan Monga, jmonga98@gmail.com JonathanMonga Needs new maintainer after transfer: NO Reason for transfer: This library deserves to be known by the flutter community, it extremely simplifies the use of the Gradient class by offering several styles already made and usable quickly without much worry. Comments: Thank you.

jeroen-meijer commented 4 years ago

Hi there,

Thanks for the package proposal. Due to recent events within the community and the world overall, we're currently quite busy and will not be able to respond to most package proposals and other community inquiries on GitHub as well as you might expect. Sorry about that. We'll keep you up to date.

Thank you for understanding.

Best regards, Jay (Flutter Community GitHub admin).

jeroen-meijer commented 4 years ago

Hi there,

Thanks again for submitting your package. It's very well done, and looks awesome!

I've tested the package on an iPhone 11 Pro Max simulator, reviewed the codebase and have found the following issues, sorted by importance.

To do before approval

As soon as these issues are fixed, the package will get rereviewed and added to the Flutter Community.

Example overflow. When clicking on a gradient in the example, the AlertDialog overflows. Please consider making it scrollable by using a SingleChildScrollView on line 79 of example/lib/main.dart like in the following example.

...
return AlertDialog(
 title: Center(child: Text(name)),
 content: SingleChildScrollView( // This is the widget that makes it scrollable.
   child: Column(
     mainAxisAlignment: MainAxisAlignment.spaceEvenly,
     crossAxisAlignment: CrossAxisAlignment.center,
...

Auto-formatting. There are multiple files that aren't formatted properly. Please go through all files and use your IDE's "Format document" functionality (instructions for VS Code, instructions for Android Studio/IntelliJ). If you're using VS Code, you could also use this extension to automate the process.

Add gradient thumbnails in example project. To better show all available gradients in the example project, please add the following code to the ListTile in example/lib/main.dart.

leading: AspectRatio(
 aspectRatio: 1,
 child: Container(
   clipBehavior: Clip.antiAlias,
   decoration: BoxDecoration(
     gradient: _findGradients(name),
     shape: BoxShape.circle,
   ),
 ),
),

Changes for the future

These are changes that aren't required now but would be nice to have in the future, either by you or another community member.

Prettier documentation. The code samples and explanations provided in the documentation are great. A spelling- and grammar-check would make it more readable (such as using proper casing and punctuation marks).

Please make these changes and tell me when you've done so in this issue. If you have any questions, don't hesitate to ask. 👍🏻

Best regards.

JonathanMonga commented 4 years ago

Thank you for accepting my package to the Flutter community, I am making all the changes you request and everything has been done.

jeroen-meijer commented 4 years ago

Hi there,

Thanks for the update, and sorry this issue hasn't progressed for a while. I'll take a look right away.

jeroen-meijer commented 4 years ago

Hi there @JonathanMonga

LGTM

Approved

Thanks for submitting this package. It has been reviewed and approved for release on the Flutter Community GitHub! 🎉 Great work. 👍🏻

What to do next

Please follow steps 3 through 7 in the Flutter Community Transfer Guide and let me know when you're done.

Good luck! 👋🏻

JonathanMonga commented 3 years ago

Thank you. Everything has been done, I'm just waiting for you now.

fluttercommunity / community