fluttercommunity / community

Flutter Community - A central place for community made Flutter content.
1.58k stars 121 forks source link

Package Proposal: local_google_fonts #48

Closed gleich closed 4 years ago

gleich commented 4 years ago

Package Proposal: local_google_fonts

Dependency name (as used in pubspec.yaml): local_google_fonts Current pub.dev link: https://pub.dev/packages/local_google_fonts#-readme-tab- Current Git repository link: https://github.com/Matt-Gleich/local_google_fonts Description: Define google fonts in your pubspec and automagically add them to you assets and your pubspec Current maintainer: Matthew Gleich, matthewgleich@gmail.com, @Matt-Gleich Needs new maintainer after transfer: NO Reason for transfer: Wanna expose more people to this package as I think it can help a lot of people. Comments: Excited πŸ˜„

jeroen-meijer commented 4 years ago

Wow...

This is really cool! πŸŽ‰

Thanks for submitting the package request. It's an absolute treat to use! I'd love to have this in the community!

Especially the terminal logging is really useful and so visually pleasing.

$ flutter pub run local_google_fonts:main
β”—β•Όβ•ΎπŸ“„ Reading Config in pubspec.yaml
   β”—β•Όβ•Ύβœ… Successfully read config
β”—β•Όβ•ΎπŸ”½ Downloading Fonts
   β”—β•Όβ•ΎπŸ”½ Downloading font: Robot
      β”—β•Όβ•ΎβŒ Failed to get font: Robot
pub finished with exit code 1

$ flutter pub run local_google_fonts:main
Waiting for another flutter command to release the startup lock...
β”—β•Όβ•ΎπŸ“„ Reading Config in pubspec.yaml
   β”—β•Όβ•Ύβœ… Successfully read config
β”—β•Όβ•ΎπŸ”½ Downloading Fonts
   β”—β•Όβ•ΎπŸ”½ Downloading font: Roboto
      β”—β•Όβ•Ύβœ… Downloaded Roboto-100i.ttf
      β”—β•Όβ•Ύβœ… Downloaded Roboto-300i.ttf
      β”—β•Όβ•Ύβœ… Downloaded Roboto-400i.ttf
...

To do before approval

As soon as these issues are fixed, the package will get rereviewed and added to the Flutter Community.

  1. Pubspec formatting and comments. Though there is a choice to auto-format (the format field), running the tool removes all comments and newlines. I figured this is probably a consequence of the YAML parser you use. Is there a possibility you could preserve comments and newlines? Alternatively, you could also add an option (something like output: all/pubspec/terminal/none, default = pubspec) that will overwrite the pubspec (like you do now), output it to the terminal, both or neither. This feature would mitigate the problem, but fixing it altogether would be the best of course.

Please make these changes and tell me when you've done so in this issue. If you have any questions, don't hesitate to ask. πŸ‘πŸ»

Best regards.

gleich commented 4 years ago

Thanks! I'll let you know when I've implemented the changes.

jeroen-meijer commented 4 years ago

Hello there.

Are there any updates to this?

Thanks!

jeroen-meijer commented 4 years ago

No response has been given after a considerable amount of time. Closing this. Feel free to ask it to be reopened.