search

fluttercommunity / flutter_launcher_icons

Flutter Launcher Icons - A package which simplifies the task of updating your Flutter app's launcher icon. Fully flexible, allowing you to choose what platform you wish to update the launcher icon for and if you want, the option to keep your old launcher icon in case you want to revert back sometime in the future. Maintainer: @MarkOSullivan94
https://pub.dev/packages/flutter_launcher_icons
MIT License
2.01k stars 406 forks source link

Fix remove alpha for iOS #464

Closed mike-500 closed 1 year ago

mike-500 commented 1 year ago

Fix for #462.

After the dependency upgrade from image 3.x.x to image 4.0.x the remove alpha for iOS no longer works and builds are rejected from the App Store. The fix is from the example here: https://github.com/brendan-duncan/image/issues/447#issuecomment-1374543054.

All tests are passing.

lcsvcn commented 1 year ago

I tested and it is working! Thanks @mike-500

TheFabbiusCorp commented 1 year ago

Hey @RatakondalaArun, @bradintheusa, can you please take a look? 🙏🏼

vlazdra commented 1 year ago

Is there really no one available to checkout these 2 lines of code? To get them merged and distributed to the community? 👀

OutdatedGuy commented 1 year ago

@MarkOSullivan94, can you quickly take a look at this, cuz lots of apps are on hold due to app store restrictions.

MarkOSullivan94 commented 1 year ago

Thanks for the ping @OutdatedGuy! Merging this in now and will have a release shortly available

MarkOSullivan94 commented 1 year ago

Thank you for submitting this change @mike-500 ❤️

MarkOSullivan94 commented 1 year ago

Also big thank you to everyone who tested the change - makes it a lot quicker for me to ship this change ❤️