fluttercommunity / flutter_launcher_icons

Flutter Launcher Icons - A package which simplifies the task of updating your Flutter app's launcher icon. Fully flexible, allowing you to choose what platform you wish to update the launcher icon for and if you want, the option to keep your old launcher icon in case you want to revert back sometime in the future. Maintainer: @MarkOSullivan94
https://pub.dev/packages/flutter_launcher_icons
MIT License
1.99k stars 396 forks source link

Allow web favicon to be built from a different source image file #519

Open galenwarren opened 1 year ago

galenwarren commented 1 year ago

This regards this issue.

It would be useful to be able to use a different source image to generate the favicon vs. the image icons for Flutter web. Two reasons:

This PR adds an image_path_favicon option to the config to allow one to override the source icon used to generate the web favicon. This would allow one to specify a non-padded icon with a transparent background to use for favicon generation and a padded icon with a solid-color background for other image generation.

MarkOSullivan94 commented 1 week ago

Good idea @galenwarren

MarkOSullivan94 commented 1 week ago

@galenwarren there's a conflict, can you address them and I'll get this merged?

galenwarren commented 3 days ago

@MarkOSullivan94 Thanks for taking a look at this!

I hope this isn't a dumb question, but what conflict are you referring to? I'm happy to take a look but it's not jumping out at me. I do see that people have added commits to coachclientconnect:support-favicon-image-file so I pulled down the latest from that branch but it seems ok, tests run.