Open galenwarren opened 1 year ago
Good idea @galenwarren
@galenwarren there's a conflict, can you address them and I'll get this merged?
@MarkOSullivan94 Thanks for taking a look at this!
I hope this isn't a dumb question, but what conflict are you referring to? I'm happy to take a look but it's not jumping out at me. I do see that people have added commits to coachclientconnect:support-favicon-image-file
so I pulled down the latest from that branch but it seems ok, tests run.
This regards this issue.
It would be useful to be able to use a different source image to generate the favicon vs. the image icons for Flutter web. Two reasons:
Favicons with transparent backgrounds work well, in general, but transparent backgrounds don't work well for icons for PWA apps (a background gets assigned which might be white, might be black, etc.)
PWA icons have the same issue that Android icons do, i.e. adaptive icons need to limit content to the "safe zone" so that the icons can be cropped as needed. Favicons don't need this extra padding and really can't afford to have it, given how small they are to begin with.
This PR adds an
image_path_favicon
option to the config to allow one to override the source icon used to generate the web favicon. This would allow one to specify a non-padded icon with a transparent background to use for favicon generation and a padded icon with a solid-color background for other image generation.