feat: add support for moving Xcode dir on iOS

SamJakob commented 1 year ago

Flutter 3.13 added support for renaming the Xcode directory on iOS, but there have been issues with both Flutter and third-party packages such as this one relying on the iOS project being named Runner. (See: https://github.com/flutter/flutter/issues/135201)

This PR adds support for renamed iOS projects by searching the ios/ directory for the first directory containing the files that flutter_launcher_icons is looking for - e.g., the first directory in ios/ that contains Assets.xcassets, instead of just ios/Runner/Assets.xcassets (effectively using the glob ios/*/Assets.xcassets in this case and using the first result).

If such a directory is not found, it will fall back to Runner (though the Runner directory should also be found under this logic) and will then fallback to existing logic.
This check is also performed once and then passed around to ensure we don't waste time scanning the ios/ directory every time such a file is needed.

MarkOSullivan94 commented 1 month ago

@SamJakob firstly - thank you for this contribution!

There's a lot of formatting changes here which are not relevant to what you are fixing, if you can remove them and get the merge conflict addressed, we can get this change merged in

SamJakob commented 1 month ago

Fair enough. I made a bunch of changes to get this working for myself locally and just PR'd them in here to see if the contributions are useful. For example, the logging changes were part of debugging this.

Since you're looking for more atomic changes, I think I'll close this PR and maybe look to open another one against the latest version with the specific changes addressed instead.

fluttercommunity / flutter_launcher_icons

feat: add support for moving Xcode dir on iOS #524