[BUG] 7 unnecessary icons being generated for iOS

fluttercommunity / flutter_launcher_icons

Flutter Launcher Icons - A package which simplifies the task of updating your Flutter app's launcher icon. Fully flexible, allowing you to choose what platform you wish to update the launcher icon for and if you want, the option to keep your old launcher icon in case you want to revert back sometime in the future. Maintainer: @MarkOSullivan94

https://pub.dev/packages/flutter_launcher_icons

MIT License

1.98k stars 393 forks source link

[BUG] 7 unnecessary icons being generated for iOS #528

Open lcsvcn opened 10 months ago

lcsvcn commented 10 months ago

:information_source: Info

Version: v0.13.1

:speech_balloon: Description

7 unnecessary icons being generated for iOS.

:scroll: Pubspec.yaml

flutter_icons:
  ios: true
  android: true
  image_path: 'assets/launcher/icon.png'
  min_sdk_android: 19
  adaptive_icon_background: '#fff'
  adaptive_icon_foreground: 'assets/launcher/foreground.png'
  remove_alpha_ios: true
  web:
    generate: true
    image_path: 'assets/launcher/foreground.png'
    background_color: '#fff'
    theme_color: '#fff'
  windows:
    generate: true
    image_path: 'assets/launcher/icon.png'
  macos:
    generate: true
    image_path: 'assets/launcher/icon.png'

We ask that you include your pubspec.yaml file as a common problem we have seen has been the pubspec.yaml file being incorrect

MarkOSullivan94 commented 8 months ago

Hi @lcsvcn thanks for reporting this

It's difficult to see all the entire file names of the icons generated, this would let me be able to compare the sizes generated versus the list of app icons required according to the Apple developer documentation.

Would be helpful if you could identify the sizes which were generated but not included in the documentation

danielvuljanic commented 7 months ago

Hi @MarkOSullivan94 after deleting the following icons in my project folder, I no longer get the error message in Xcode v17 (Deployment target iOS v12.0). Maybe this will help.

ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-50x50@1x.png ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-50x50@2x.png ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-57x57@1x.png ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-57x57@2x.png ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-72x72@1x.png ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-72x72@2x.png

Albert221 commented 5 months ago

These are the icons needed in All Sized in Xcode 15.3. This package currently generates some sizes that are not used and doesn't generate a few sizes that are needed.

lacostej commented 3 weeks ago

Anyone interested in trying the fix?