onBack stream not closed - Githubissues

fluttercommunity / flutter_webview_plugin

Community WebView Plugin - Allows Flutter to communicate with a native WebView.

https://pub.dev/packages/flutter_webview_plugin

Other

1.48k stars 930 forks source link

onBack stream not closed #774

Open glasody opened 4 years ago

glasody commented 4 years ago

System info

Issue occurs on: both Plugin version: 0.3.11 Flutter doctor output:

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.900], locale en-NZ)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[√] VS Code, 64-bit edition (version 1.46.0)
[√] Connected device (1 available)

• No issues found!

Steps to Reproduce

Navigate to the file base.dart in the plugin lib.
scroll down to dispose method.

as you can see also in the image, the _onBack stream controller is created but never closed in the dispose. Not sure if this was on purpose or not.