search

fluttercommunity / font_awesome_flutter

The Font Awesome Icon pack available as Flutter Icons
Other
838 stars 238 forks source link

New Pro pack alpha `search` => `magnifying-glass` #159

Closed amkuchta closed 2 years ago

amkuchta commented 3 years ago

Although this may not be an issue yet, the v6 alpha also changes search to magnifying-glass; this will need to be updated in the example app, as search no longer resolves properly.

michaelspiss commented 3 years ago

Thank you so much for bringing this to my attention! Changed icon names probably warrant a new major version as well, as the pacckage is no longer fully backwards compatible to version 5 icons.

stedekay commented 3 years ago

I upgraded font_awesome_flutter to the current release (9.1.0) and had a lot of renamings (like search, commentAlt, calendarAlt, etc.) All these icon names are aliases in the icons.json. I don't know if they were aliases before but it seems that it would be helpful when your package can also handle the aliases.

michaelspiss commented 2 years ago

I added aliases to version 10, marked them all as @Deprecated however. The decision to mark them as such is based on the uncertainty, of whether aliases are here to stay or if they are solely for the purpose of making the transition to version 6 easier. It should also guide users towards the new icon names, as the deprecation notice also shows the new icon name.