search

fluttercommunity / font_awesome_flutter

The Font Awesome Icon pack available as Flutter Icons
Other
834 stars 236 forks source link

tripadvisor icon missing #187

Closed alsofr closed 2 years ago

alsofr commented 2 years ago

Hi, the following commit removed the Tripadvisor icon in version 9.2.0

https://github.com/fluttercommunity/font_awesome_flutter/commit/32a780255717987fcdbb190ab281c25c3f00f3ab#diff-7170115914305e000a770bb2d1062f8e26958034c9d18238152a8e090a03dd0b

https://github.com/fluttercommunity/font_awesome_flutter/pull/180/files

Which is then causing other projects like https://pub.dev/packages/dynamic_widget to fail when using the latest version of the project.

Was is intentional (and then I would create a PR to the dynamic_widget project instead) or is it a mistake to have removed it?

michaelspiss commented 2 years ago

Hi, this is intentional. Font awesome removed the tripadvisor logo in version 5.15.4 as per tripadvisor's request (according to the changelog).

alsofr commented 2 years ago

Thank you for the info and the super fast answer! I'll create a PR in the other library then.