search

fluttercommunity / get_it

Get It - Simple direct Service Locator that allows to decouple the interface from a concrete implementation and to access the concrete implementation from everywhere in your App. Maintainer: @escamoteur
https://pub.dev/packages/get_it
MIT License
1.32k stars 141 forks source link

isFinal test #329

Closed subzero911 closed 1 year ago

subzero911 commented 1 year ago

https://github.com/fluttercommunity/get_it/issues/326

I added a test but it fails for some reason.

TestClass is not removed after popScope().

escamoteur commented 1 year ago

I merge and debug

escamoteur commented 1 year ago

you have to await popScope

escamoteur commented 1 year ago

because dispose functions can be async if you don't await in the test the expect will get executed before the scope is popped

escamoteur commented 1 year ago

if fixed it and pushed it again

escamoteur commented 1 year ago

do you also update the readme?

subzero911 commented 1 year ago

https://github.com/fluttercommunity/get_it/pull/330