search

fluttercommunity / redux.dart

Redux for Dart
https://pub.dev/packages/redux
MIT License
515 stars 61 forks source link

2.1.0 version #16

Closed brianegan closed 6 years ago

brianegan commented 6 years ago

Hey hey -- this is the 2.1.0 version which includes the distinct option. Wanted to get your opinion on the changes.

In the last PR, I added distinct as a public field, but that requires us to bump to 3.0.0 b/c it isn't backwards compatible (folks implementing the Store would be forced to handle the change).

In order to make this a non-breaking change, I've made distinct only a parameter of the constructor and create the reduceAndNotify NextDispatcher using it.

The alternative would be to make _distinct a private field and use that in the reduceAndNotify function -- I don't think there's a big difference either way but wanted to run this by you before I ship it!

johnpryan commented 6 years ago

No need - this looks good to me