search

fluttercommunity / redux.dart

Redux for Dart
https://pub.dev/packages/redux
MIT License
519 stars 61 forks source link

Remove unused dart:async imports. #67

Closed srawlins closed 4 years ago

srawlins commented 4 years ago

As of Dart 2.1, Future/Stream have been exported from dart:core.

MichaelMarner commented 4 years ago

If we're going to do this, we would also need to change the engine requirements in pubspec.yaml to have a minimum of Dart 2.1:

environment:
  sdk: '>=2.1.0 <3.0.0'

Travis is currently failing the build because of this version requirements mismatch:

hint • The class 'Future' wasn't exported from 'dart:core' until version 2.1, but this code is required to be able to run on earlier versions. • test/middleware_test.dart:82:7 • sdk_version_async_exported_from_core

Making this change would prevent using the current version of Redux with older versions of Flutter. However, Flutter stable currently uses Dart 2.10.2, so maybe it's a non-issue.

srawlins commented 4 years ago

You're correct! My bad, let's leave it.