fluttercommunity / redux.dart

Redux for Dart
https://pub.dev/packages/redux
MIT License
515 stars 61 forks source link

Null safety support #74

Closed lig closed 3 years ago

lig commented 3 years ago

This is a pretty naive migration to support null safety in redux.

In my opinion, it would be beneficial to have Store._state always be non-nullable. The issue is that the current logic in Store.teardown() looks hardly replaceable.

Notes:

Todo:

codecov-io commented 3 years ago

Codecov Report

Merging #74 (5320710) into master (8872c0b) will decrease coverage by 1.86%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   92.10%   90.24%   -1.87%     
==========================================
  Files           2        2              
  Lines          38       41       +3     
==========================================
+ Hits           35       37       +2     
- Misses          3        4       +1     
Impacted Files Coverage Δ
lib/src/store.dart 85.71% <85.71%> (-2.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8872c0b...5320710. Read the comment docs.