fluttercommunity / wakelock_plus

Flutter plugin that allows you to keep the device screen awake on Android, iOS, macOS, Windows, Linux, and web.
BSD 3-Clause "New" or "Revised" License
49 stars 38 forks source link

chore: loosen dependency constraint to support package_info_plus v8 and v9 #52

Closed josxha closed 1 month ago

josxha commented 2 months ago

Changes

This pull request loosens the constraint to support v6, v7 and v8 of package_info_plus.

Description

The latest version of package_info_plus is 8.0.0 while the constraint in wakelock_plus is set to <8.0.0. There is only one breaking change in package_info_plus that wakelock_plus:

BREAKING FEAT(package_info_plus): Switch to SHA-256 for buildSignature on Android

package_info_plus isn't affected by this breaking change because the only usage is appName in wakelock_plus_linux_plugin.dart.

diegotori commented 2 months ago

@josxha thanks for your PR. Once the tests go green, then I'll approve.

Since I'm currently out of the country, I'll be able to deploy a new build on Tuesday the earliest.

In the meantime, you can add a dependency override to this new package_info_plus version in your pubspec.

josxha commented 2 months ago

Thanks for your response @diegotori! I tried to look into the failed CI. I don't think that there isn't really a problem and they just ran into a timeout that one time. Althrough, I can't really debug the workflows while they need manual approval to run. But all tests went trhough successfully when I triggered them in my fork.

mrwebbeast commented 1 month ago

Hi Guys any updates on this