search

fluttercommunity / wakelock_plus

Flutter plugin that allows you to keep the device screen awake on Android, iOS, macOS, Windows, Linux, and web.
BSD 3-Clause "New" or "Revised" License
71 stars 54 forks source link

Added conditional export of all 'io' implementations. Addresses issue… #66

Closed uldall closed 4 months ago

uldall commented 4 months ago

Addresses #65

Description

Only export Linux, MacOS and Windows implementations when not on web.

uldall commented 4 months ago

I am not an expert on how the export keyword works, so hopefully someone else can determine if this approach is correct.

diegotori commented 4 months ago

@uldall Thanks for your contribution.

This actually works fine because you're properly bucketing dart:io usage away from web.

Once the automation passes, then I'll approve.

diegotori commented 4 months ago

@uldall since it's the fourth of July holiday weekend here in the States, the earliest that this will get deployed is on Monday.

Thanks for your contribution.

uldall commented 4 months ago

@uldall since it's the fourth of July holiday weekend here in the States, the earliest that this will get deployed is on Monday.

Thanks for your contribution.

No problem, thank you for taking your time to look into this :)

uldall commented 4 months ago

Hi @diegotori, would it possible to get this merged and released? Then I wouldn't have to keep a separate build which would be quite nice :) Thank you in advance!

diegotori commented 4 months ago

@uldall sure. Lemme just merge it first. In the meantime, override the dependency so that it gets it from git main

diegotori commented 4 months ago

@uldall released as part of version 1.2.6. Once again, thanks for your contribution.