search

flutterjanus / flutter_janus_client

A plugin that allows the flutter app to communicate with a Janus server using different transport mechanisms, such as WebSocket and HTTP(rest). It features a developer-friendly api to interact with various WebRTC Janus Plugins. Hence, it can be considered as a swiss-knife for WebRTC solutions.
MIT License
134 stars 76 forks source link

Cant use RTCIceServer without credential/password #164

Closed Clon1998 closed 6 months ago

Clon1998 commented 6 months ago

Hey, the current implementation of your RTCIceServer class contains a bug that causes an issue on the native side while building the peerconnection.

In particular, it is impossible to add/use Ice candidates that do not enforce a username/credential as the toMap() method will include these fields with values null when submitting the init request to the platform code.

shivanshtalwar commented 6 months ago

You are right it can be easily solved, by adding a null check in toMap would you like to do a pr for the same?

Clon1998 commented 6 months ago

You are right it can be easily solved, by adding a null check in toMap would you like to do a pr for the same?

Just created the PR